Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use BAM_RSEQC subworkflow #155

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Use BAM_RSEQC subworkflow #155

merged 2 commits into from
Aug 6, 2024

Conversation

edmundmiller
Copy link
Collaborator

@edmundmiller edmundmiller commented Aug 4, 2024 •
edited
Loading

  • build: nf-core modules install bam_rseqc
  • refactor: Use bam_rseqc subworkflow

@edmundmiller edmundmiller self-assigned this Aug 4, 2024
@edmundmiller edmundmiller added this to the 2.3.0 milestone Aug 4, 2024
@edmundmiller edmundmiller marked this pull request as draft August 4, 2024 12:56
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 4, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit bd7de60

+| ✅ 196 tests passed       |+
#| ❔   4 tests were ignored |#
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in README.md: Describe the minimum required steps to execute the pipeline, e.g. how to prepare samplesheets.
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml
  • files_unchanged - File ignored due to lint config: assets/email_template.html
  • actions_ci - actions_ci

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-08-06 16:25:49

@edmundmiller edmundmiller force-pushed the bam_rseqc branch 2 times, most recently from 79c7e39 to 56a613f Compare August 5, 2024 01:32
@edmundmiller edmundmiller marked this pull request as ready for review August 5, 2024 02:28
nictru
nictru approved these changes Aug 6, 2024
View reviewed changes
Copy link

@nictru nictru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edmundmiller edmundmiller merged commit 15e0ff8 into dev Aug 6, 2024
14 of 15 checks passed
@edmundmiller edmundmiller deleted the bam_rseqc branch August 6, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nictru nictru nictru approved these changes

Assignees

@edmundmiller edmundmiller

Labels
None yet
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@edmundmiller @nictru